toddmeng-db commented on code in PR #2789: URL: https://github.com/apache/arrow-adbc/pull/2789#discussion_r2078145962
########## csharp/src/Drivers/Apache/Spark/SparkHttpMessageHandlerFactory.cs: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +using System; +using System.Collections.Generic; +using System.Net.Http; + +namespace Apache.Arrow.Adbc.Drivers.Apache.Spark +{ + /// <summary> + /// Factory for creating HTTP clients with proper configuration + /// </summary> + public class SparkHttpMessageHandlerFactory Review Comment: I'm taking a look at the implementation; other concern is the `NewHttpClientHandler` method is static, and is called by different httpconnections (`SparkHttpConnection`, `ImpalaHttpConnection`, `HiveServer2HttpConnection`). Since these classes all inherit from `HiveServer2Connection` (and we probably don't want to expose http logic at this layer), there is no obvious place to initialize http client with proxy logic for all child http connections. I think it actually makes some sense to use factory here, then Edit, Discussed off-line: We could still put the logic in `NewHttpClientHandler` method (or new method), since that class is performing many different http configurations, anyways. @CurtHagenlocher -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
