eric-wang-1990 commented on code in PR #2789:
URL: https://github.com/apache/arrow-adbc/pull/2789#discussion_r2076570445
##########
csharp/src/Drivers/Apache/Spark/SparkParameters.cs:
##########
@@ -34,6 +34,48 @@ public class SparkParameters
public const string DataTypeConv = "adbc.spark.data_type_conv";
public const string ConnectTimeoutMilliseconds =
"adbc.spark.connect_timeout_ms";
public const string UserAgentEntry = "adbc.spark.user_agent_entry";
+
+ // Proxy configuration parameters
+ /// <summary>
+ /// Whether to use a proxy for HTTP connections.
+ /// Default value is 0 (disabled) if not specified.
+ /// </summary>
+ public const string UseProxy = "UseProxy";
Review Comment:
This should be a general option setting for all hive traffic. Conside
something like adbc.http_options.proxy.use_proxy, added to here:
https://github.com/apache/arrow-adbc/blob/e045731b24f00df50e9c9f50e5ba6ec632cbd3ef/csharp/src/Drivers/Apache/Hive2/HiveServer2Parameters.cs#L55
##########
csharp/src/Drivers/Apache/Spark/SparkHttpMessageHandlerFactory.cs:
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+using System;
+using System.Collections.Generic;
+using System.Net.Http;
+
+namespace Apache.Arrow.Adbc.Drivers.Apache.Spark
+{
+ /// <summary>
+ /// Factory for creating HTTP clients with proper configuration
+ /// </summary>
+ public class SparkHttpMessageHandlerFactory
Review Comment:
We should not need this, here is already returning a handler:
https://github.com/apache/arrow-adbc/blob/e045731b24f00df50e9c9f50e5ba6ec632cbd3ef/csharp/src/Drivers/Apache/Spark/SparkHttpConnection.cs#L151.
We can just call the proxy configurator on top of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
