alamb commented on code in PR #7484:
URL: https://github.com/apache/arrow-rs/pull/7484#discussion_r2080271220
##########
parquet/benches/arrow_reader.rs:
##########
@@ -1307,6 +1386,17 @@ fn add_benches(c: &mut Criterion) {
);
group.finish();
+ // primitive int64 / logical uint64 benchmarks
+ let mut group = c.benchmark_group("arrow_array_reader/UInt64Array");
+ bench_primitive::<Int64Type>(
Review Comment:
I was confused at first -- I thought thi this is meant to be
```suggestion
bench_primitive::<UInt64Type>(
```
However, the type is the parquet type not the arrow / logical type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
