mderoy opened a new pull request, #46519:
URL: https://github.com/apache/arrow/pull/46519

   ### Rationale for this change
   Some applications have their own way of logging, however there is no way for 
the user to implement a custom logger to get more information from arrow
   
   ### What changes are included in this PR?
   - A virtual S3Logger class which the user can implement
   - A wrapper class in arrow which implements 
Aws::Utils::Logging::DefaultLogSystem
   The user can then add their own S3Logger derived class to S3GlobalOptions 
and they will be wrapped by WrappedS3Logger and given to S3 when we initialize
   As I understand it, arrow doesn't want to expose aws headers directly, since 
a user may have linked their own awssdk at a different version. This approach 
works around that issue. I'm happy to retool it in a different direction with 
review feedback.
   
   ### Are these changes tested?
   They are tested our fork in arrow 13.0.0.0 but I have not tested with the 
latest code, as I'm unable to build main in my environment (it looks like a new 
build dependency on ninja was added and I'm not able to install it at the 
moment on my system). I have opened this PR via a cherry-pick of my changes.
   
   ### Are there any user-facing changes?
   No, these settings are for advanced users of the C++ sdk with S3FS


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to