IIFE commented on code in PR #2858:
URL: https://github.com/apache/arrow-adbc/pull/2858#discussion_r2106377728
##########
c/cmake_modules/BuildUtils.cmake:
##########
@@ -240,6 +240,21 @@ function(ADD_ARROW_LIB LIB_NAME)
OUTPUT_NAME ${LIB_NAME}
VERSION "${ADBC_FULL_SO_VERSION}"
SOVERSION "${ADBC_SO_VERSION}")
+
+ if(MSVC)
Review Comment:
I was torn between the two, leaned more towards MSVC as the compiler choice
is what's driving the behaviour. Happy to use WIN32 though, both will lead to
the same result. Same comment applies to the rest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
