toddmeng-db commented on code in PR #2896:
URL: https://github.com/apache/arrow-adbc/pull/2896#discussion_r2116496526
##########
csharp/src/Drivers/Databricks/DatabricksStatement.cs:
##########
@@ -41,6 +41,18 @@ internal class DatabricksStatement : SparkStatement,
IHiveServer2Statement
public DatabricksStatement(DatabricksConnection connection)
: base(connection)
{
Review Comment:
@eric-wang-1990 I think it makes more sense to do the schema filtering here,
instead of in powerbi*. Do you think this makes sense?
So, now if schemaname is provided by default namespace, (then by default we
use that)
Also, this PR will affect other metadata calls (to use the default namespace
if user does not pass in relevant catalog + schema information). What do you
think?
##########
csharp/test/Drivers/Databricks/StatementTests.cs:
##########
@@ -92,7 +92,7 @@ internal class LongRunningStatementTimeoutTestData :
ShortRunningStatementTimeou
{
public LongRunningStatementTimeoutTestData()
{
Review Comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
