toddmeng-db commented on code in PR #2896:
URL: https://github.com/apache/arrow-adbc/pull/2896#discussion_r2119456795
##########
csharp/src/Drivers/Databricks/DatabricksStatement.cs:
##########
@@ -41,6 +41,18 @@ internal class DatabricksStatement : SparkStatement,
IHiveServer2Statement
public DatabricksStatement(DatabricksConnection connection)
: base(connection)
{
Review Comment:
What I meant, is that with this PR, it is impossible to make GetTables call
with no catalog attached to the request, since OpenSessionResp seems to
typically have a default catalog in the response (even if not user provided).
Seems like this behavior happens in odbc too.
So if I wanted to fetch all tables in the metastore, I couldn't use
GetTables after this PR. And the way this PR is written, same for schemas, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
