toddmeng-db commented on code in PR #2896:
URL: https://github.com/apache/arrow-adbc/pull/2896#discussion_r2122866805
##########
csharp/src/Drivers/Databricks/DatabricksStatement.cs:
##########
@@ -41,6 +41,19 @@ internal class DatabricksStatement : SparkStatement,
IHiveServer2Statement
public DatabricksStatement(DatabricksConnection connection)
: base(connection)
{
+ // set the catalog name for legacy compatibility
+ // TODO: use catalog and schema fields in hiveserver2 connection
instad of DefaultNamespace so we don't need to cast
+ var defaultNamespace =
((DatabricksConnection)Connection).DefaultNamespace;
+ if (defaultNamespace != null) {
+ if (CatalogName == null)
+ {
+ CatalogName = defaultNamespace.CatalogName;
+ }
+ if (SchemaName == null)
+ {
+ SchemaName = defaultNamespace.SchemaName;
Review Comment:
I ran the call directly to odbc (skipping powerbi). If both catalog and
schema are provided, schema is still % by default
Listing tables 'catalog : peco, schemaPattern : %, tableTypes : null,
tableName : %'
##########
csharp/src/Drivers/Databricks/DatabricksStatement.cs:
##########
@@ -41,6 +41,19 @@ internal class DatabricksStatement : SparkStatement,
IHiveServer2Statement
public DatabricksStatement(DatabricksConnection connection)
: base(connection)
{
+ // set the catalog name for legacy compatibility
+ // TODO: use catalog and schema fields in hiveserver2 connection
instad of DefaultNamespace so we don't need to cast
+ var defaultNamespace =
((DatabricksConnection)Connection).DefaultNamespace;
+ if (defaultNamespace != null) {
+ if (CatalogName == null)
+ {
+ CatalogName = defaultNamespace.CatalogName;
+ }
+ if (SchemaName == null)
+ {
+ SchemaName = defaultNamespace.SchemaName;
Review Comment:
I ran the call directly to odbc (not via powerbi). If both catalog and
schema are provided, schema is still % by default
Listing tables 'catalog : peco, schemaPattern : %, tableTypes : null,
tableName : %'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
