westonpace commented on a change in pull request #9892:
URL: https://github.com/apache/arrow/pull/9892#discussion_r608829064



##########
File path: cpp/src/arrow/dataset/scanner.h
##########
@@ -32,6 +32,7 @@
 #include "arrow/memory_pool.h"
 #include "arrow/type_fwd.h"
 #include "arrow/util/async_generator.h"
+#include "arrow/util/thread_pool.h"

Review comment:
       Well, you caught me out, they're not all named `MakeXyz` :smile: 
   
   ```
         auto scan_fut = CollectAsyncGenerator(std::move(scan_gen))
                             .Then([state, id](const RecordBatchVector& rbs) {
                               state->Emplace(rbs, id);
   ```
   
   This call to `CollectAsyncGenerator` requires the include.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to