EnricoMi commented on PR #46626: URL: https://github.com/apache/arrow/pull/46626#issuecomment-2939137725
> @pitrou what do you think about [9c88744](https://github.com/apache/arrow/commit/9c8874402c45f0a43432b2207f81a97cecbe6334)? It is essential that `AssertSecurelyCleared` really catches leaked secrets, so I added tests for that. Capturing the assertion failures was tricky, but I did not want to touch the `ASSERT_EQ` in `AssertSecurelyCleared`. Nevermind, I have found `testing::AssertionResult`: https://google.github.io/googletest/advanced.html#using-a-function-that-returns-an-assertionresult. Allows to test assertion code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
