lidavidm commented on code in PR #2918: URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2131497275
########## c/driver_manager/adbc_driver_manager.cc: ########## @@ -114,7 +125,187 @@ struct OwnedError { } }; +std::filesystem::path UserConfigDir() { + std::filesystem::path config_dir; +#if defined(_WIN32) + auto dir = std::getenv("AppData"); + if (dir) { + config_dir = std::filesystem::path(dir); + config_dir /= "ADBC/drivers"; + } +#elif defined(__APPLE__) + auto dir = std::getenv("HOME"); + if (dir) { + config_dir = std::filesystem::path(dir); + config_dir /= "Library/Application Support/ADBC"; + } +#elif defined(__linux__) + auto dir = std::getenv("XDG_CONFIG_HOME"); + if (!dir) { + dir = std::getenv("HOME"); + if (dir) { + config_dir = std::filesystem::path(dir); + } + } else { + config_dir = std::filesystem::path(dir); + } + + if (!config_dir.empty()) { + config_dir /= "adbc"; + } +#endif + + return config_dir; Review Comment: I suppose it doesn't hurt to either note the platform/architecture in the manifest or in the filepath somehow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org