alamb commented on a change in pull request #9806:
URL: https://github.com/apache/arrow/pull/9806#discussion_r609651423
##########
File path: rust/datafusion/src/physical_plan/union.rs
##########
@@ -60,15 +60,31 @@ impl ExecutionPlan for UnionExec {
/// Output of the union is the combination of all output partitions of the
inputs
fn output_partitioning(&self) -> Partitioning {
- // Sums all the output partitions
- let num_partitions = self
- .inputs
+ let intial: Option<Partitioning> = None;
+ self.inputs
.iter()
- .map(|plan| plan.output_partitioning().partition_count())
- .sum();
- // TODO: this loses partitioning info in case of same partitioning
scheme (for example `Partitioning::Hash`)
- // https://issues.apache.org/jira/browse/ARROW-11991
- Partitioning::UnknownPartitioning(num_partitions)
+ .fold(intial, |acc, input| {
+ match (acc, input.output_partitioning()) {
+ (None, partition) => Some(partition),
+ (
+ Some(Partitioning::Hash(mut vector_acc, size_acc)),
+ Partitioning::Hash(vector, size),
+ ) => {
+ vector_acc.append(&mut vector.clone());
Review comment:
I would have expected
```
pub trait PhysicalExpr: Send + Sync + Display + Debug + PartialEq
```
To be the correct way as it says that everything that implements
`PhysicalExpr` also needs to implement `PartialEq`. You would then have to
`#[derive(PartialEq)]` or `impl PartialEq` for all structs that claim to `impl
PhysicalExpr`
What error did you get when you tried that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
