kou commented on code in PR #46830:
URL: https://github.com/apache/arrow/pull/46830#discussion_r2151311477
##########
cpp/src/arrow/acero/meson.build:
##########
@@ -80,12 +80,12 @@ arrow_acero_srcs = [
arrow_acero_lib = library(
'arrow-acero',
sources: arrow_acero_srcs,
- dependencies: [arrow_dep],
+ dependencies: [arrow_dep, arrow_compute_dep],
Review Comment:
`arrow_compute_dep` must be placed before `arrow_dep` because
`arrow_compute_dep` depends on `arrow_dep`:
```suggestion
dependencies: [arrow_compute_dep, arrow_dep],
```
##########
cpp/src/arrow/compute/meson.build:
##########
@@ -96,16 +127,14 @@ compute_tests = {
# - value_counts
#
# Also see: GH-34388, GH-34615
Review Comment:
Should we update this comment block?
##########
cpp/src/arrow/compute/meson.build:
##########
@@ -59,15 +92,13 @@ exc = executable(
'exec_test.cc',
'kernel_test.cc',
'registry_test.cc',
- ] + arrow_compute_testing_srcs,
- dependencies: [arrow_test_dep],
+ ],
+ dependencies: [arrow_test_dep, arrow_compute_core_test_dep],
Review Comment:
```suggestion
dependencies: [arrow_compute_core_test_dep, arrow_test_dep],
```
##########
cpp/src/arrow/acero/meson.build:
##########
@@ -133,7 +133,19 @@ foreach key, val : arrow_acero_benchmarks
exc = executable(
key,
sources: val['sources'] + arrow_acero_testing_sources,
- dependencies: [arrow_acero_dep, arrow_benchmark_dep, gmock_dep],
+ dependencies: [
+ arrow_acero_dep,
+ arrow_compute_test_dep,
+ arrow_benchmark_dep,
+ gmock_dep,
+ ],
)
benchmark(key, exc)
endforeach
+
+pkg.generate(
+ filebase: 'arrow-acero',
+ name: 'Apache Arrow Acero Engine',
+ description: 'Apache Arrow\'s Acero Engine',
+ requires: ['arrow', 'arrow-compute'],
Review Comment:
We don't need `arrow` here because `arrow-compute` has `Requires: arrow`:
```suggestion
requires: ['arrow-compute'],
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
