alamb commented on PR #7671:
URL: https://github.com/apache/arrow-rs/pull/7671#issuecomment-2981644047

   Github is being annoying and not letting me submit this as a reivew. Here 
are my comments:
   
   Thank you @brancz  -- this is really cool
   
   I found following the extension logic quite challenging as the tests are not 
in terms of RunArrays but instead in terms of the child data
   
   I think the reason to add `build_extend` is to support higher level kernels 
like `take` -- would it be possible to add tests for those kernels in terms of 
RunArrays that would demonstrate that the code in this PR works as intended? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to