dinse commented on code in PR #46829:
URL: https://github.com/apache/arrow/pull/46829#discussion_r2155315044
##########
cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc:
##########
@@ -2926,6 +2933,22 @@ TYPED_TEST(TestUnaryArithmeticFloating, Sign) {
this->AssertUnaryOp(sign, this->MakeScalar(max), this->MakeScalar(1));
}
+TYPED_TEST(TestUnaryArithmeticHalfFloat, Negate) {
Review Comment:
Do you mean add HalfFloat to FloatingTypes so TestUnaryArithmeticFloating
picks it up? TestUnaryArithmeticFloating tests several unary func like abs,
sqrt, exp, log, trig that are still unimplemented for float16. Would I have to
change all of those to skip based on ArrowType/CType?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
