kou commented on code in PR #3006:
URL: https://github.com/apache/arrow-adbc/pull/3006#discussion_r2159605538
##########
csharp/Directory.Build.props:
##########
@@ -53,7 +53,7 @@
<Authors>The Apache Software Foundation</Authors>
<PackageIcon>feather.png</PackageIcon>
<!-- We can't use PackageLicenseExpression; the license file also contains
3rd-party notices. -->
Review Comment:
If we use PackageLicenseExpression, we should remove this comment.
##########
csharp/Directory.Build.props:
##########
@@ -53,7 +53,7 @@
<Authors>The Apache Software Foundation</Authors>
<PackageIcon>feather.png</PackageIcon>
<!-- We can't use PackageLicenseExpression; the license file also contains
3rd-party notices. -->
- <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
+ <PackageLicenseExpression>APACHE-2.0</PackageLicenseExpression>
Review Comment:
We should use SPDX license identifier:
https://learn.microsoft.com/en-us/nuget/reference/msbuild-targets#pack-target-inputs
> PackageLicenseExpression An [SPDX license
identifier](https://spdx.org/licenses/) or expression, for example, Apache-2.0.
For more information, see [Packing a license expression or a license
file](https://learn.microsoft.com/en-us/nuget/reference/msbuild-targets#packing-a-license-expression-or-a-license-file).
```suggestion
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
