trxcllnt commented on a change in pull request #9961:
URL: https://github.com/apache/arrow/pull/9961#discussion_r610380913
##########
File path: js/gulp/compile-task.js
##########
@@ -25,12 +25,12 @@ const typescriptTask = require('./typescript-task');
const { arrowTask, arrowTSTask } = require('./arrow-task');
const compileTask = ((cache) => memoizeTask(cache, function compile(target,
format, ...args) {
- return target === `src` ? Observable.empty()
- : target === npmPkgName ? arrowTask(target, format,
...args)()
- : target === `ts` ? arrowTSTask(target, format,
...args)()
- : format === `umd` ? target === `es5` ? closureTask(target, format,
...args)()
- : minifyTask(target, format,
...args)()
- : typescriptTask(target,
format, ...args)();
+ return target === `src` ? Observable.empty()
+ : target === npmPkgName ? arrowTask(target, format,
...args)()
+ : target === `ts` ? arrowTSTask(target,
format, ...args)()
+ : format === `umd` ? target === `es2015` ? closureTask(target,
format, ...args)()
Review comment:
Does Closure finally produce good ES2015+? I think we've only been using
it to make the ES5 UMD bundle because it was either bad, or didn't always work
when `language_out` was ES2015+.
If it does, I'd be happy to rip out Webpack + Terser and use Closure for all
the UMD bundles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
