trxcllnt commented on a change in pull request #9961:
URL: https://github.com/apache/arrow/pull/9961#discussion_r610813521
##########
File path: js/gulp/compile-task.js
##########
@@ -25,12 +25,12 @@ const typescriptTask = require('./typescript-task');
const { arrowTask, arrowTSTask } = require('./arrow-task');
const compileTask = ((cache) => memoizeTask(cache, function compile(target,
format, ...args) {
- return target === `src` ? Observable.empty()
- : target === npmPkgName ? arrowTask(target, format,
...args)()
- : target === `ts` ? arrowTSTask(target, format,
...args)()
- : format === `umd` ? target === `es5` ? closureTask(target, format,
...args)()
- : minifyTask(target, format,
...args)()
- : typescriptTask(target,
format, ...args)();
+ return target === `src` ? Observable.empty()
+ : target === npmPkgName ? arrowTask(target, format,
...args)()
+ : target === `ts` ? arrowTSTask(target,
format, ...args)()
+ : format === `umd` ? target === `es2015` ? closureTask(target,
format, ...args)()
Review comment:
Closure compiler is a mystery to me as well :joy:. I have to doc-dive
every time we update to find what the new magic string combinations are. lol
yuck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
