scovich commented on PR #7752: URL: https://github.com/apache/arrow-rs/pull/7752#issuecomment-3001701477
> I wonder if we should try and write some (negative) tests to exercise the error paths 🤔 We need better error-path testing in general, but I don't know how to test this one specifically? I don't have access to any 32-bit hardware and AFAIK, CI is also running 64-bit architectures. It's probably not even possible to trigger a 64-bit overflow because `u64::MAX` is `u32::MAX*u32::MAX + 2*u32::MAX`. Variant spec _might_ have places that add or multiply two malicious u32 values, but I don't think it ever does a product followed by two sums? And that would only get _to_ the max, not beyond it. Even if we managed to cause 64-bit overflow in a couple very limited cases, it would be a far cry from full coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
