harshmotw-db commented on code in PR #7783:
URL: https://github.com/apache/arrow-rs/pull/7783#discussion_r2167845968
##########
parquet-variant/src/variant.rs:
##########
@@ -1031,6 +1033,57 @@ impl From<VariantDecimal16> for Variant<'_, '_> {
}
}
+impl TryFrom<&Number> for Variant<'_, '_> {
+ type Error = ArrowError;
+
+ fn try_from(n: &Number) -> Result<Self, Self::Error> {
Review Comment:
Thanks for the code pointer! Do you think we could implement custom decimal
parsing as a follow up? I think 2^96 is a good bound for now even though the
Variant spec allows for a larger width (about 2^128).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
