harshmotw-db commented on code in PR #7783:
URL: https://github.com/apache/arrow-rs/pull/7783#discussion_r2167830142
##########
parquet-variant/src/from_json.rs:
##########
@@ -0,0 +1,97 @@
+use crate::variant_buffer_manager::VariantBufferManager;
+use crate::{ListBuilder, ObjectBuilder, Variant, VariantBuilder};
+use arrow_schema::ArrowError;
+use serde_json::{Map, Value};
+
+/// Eventually, internal writes should also be performed using
VariantBufferManager instead of
+/// ValueBuffer and MetadataBuffer so the caller has control of the memory.
+/// Returns a pair <value_size, metadata_size>
+pub fn json_to_variant<'a, T: VariantBufferManager>(
+ json: &str,
+ variant_buffer_manager: &'a mut T,
+) -> Result<(usize, usize), ArrowError> {
+ let mut builder = VariantBuilder::new();
+ let json: Value = serde_json::from_str(json)
+ .map_err(|e| ArrowError::InvalidArgumentError(format!("JSON format
error: {}", e)))?;
+
+ build_json(&json, &mut builder)?;
+ let (metadata, value) = builder.finish();
+ let value_size = value.len();
+ let metadata_size = metadata.len();
+
+ // Write to caller's buffers - Remove this when the library internally
writes to the caller's
+ // buffers anyway
+ variant_buffer_manager.ensure_metadata_buffer_size(metadata_size)?;
+ variant_buffer_manager.ensure_value_buffer_size(value_size)?;
+ let caller_metadata_buffer =
variant_buffer_manager.borrow_metadata_buffer();
+
caller_metadata_buffer[..metadata_size].copy_from_slice(metadata.as_slice());
+ let caller_value_buffer = variant_buffer_manager.borrow_value_buffer();
+ caller_value_buffer[..value_size].copy_from_slice(value.as_slice());
+ Ok((metadata_size, value_size))
+}
+
+fn build_json(json: &Value, builder: &mut VariantBuilder) -> Result<(),
ArrowError> {
+ match json {
+ Value::Null => builder.append_value(Variant::Null),
+ Value::Bool(b) => builder.append_value(*b),
+ Value::Number(n) => {
+ let v: Variant = n.try_into()?;
+ builder.append_value(v)
+ }
+ Value::String(s) => builder.append_value(s.as_str()),
+ Value::Array(arr) => {
+ let mut list_builder = builder.new_list();
+ build_list(arr, &mut list_builder)?;
+ list_builder.finish();
+ }
+ Value::Object(obj) => {
+ let mut obj_builder = builder.new_object();
+ build_object(obj, &mut obj_builder)?;
+ obj_builder.finish();
+ }
+ };
+ Ok(())
+}
+
+fn build_list(arr: &Vec<Value>, builder: &mut ListBuilder) -> Result<(),
ArrowError> {
+ for val in arr {
+ match val {
+ Value::Null => builder.append_value(Variant::Null),
+ Value::Bool(b) => builder.append_value(*b),
+ Value::Number(n) => {
+ let v: Variant = n.try_into()?;
+ builder.append_value(v)
+ }
+ Value::String(s) => builder.append_value(s.as_str()),
+ Value::Array(arr) => {
+ let mut list_builder = builder.new_list();
+ build_list(arr, &mut list_builder)?;
+ list_builder.finish()
+ }
+ Value::Object(obj) => {
+ let mut obj_builder = builder.new_object();
+ build_object(obj, &mut obj_builder)?;
+ obj_builder.finish();
+ }
+ }
+ }
+ Ok(())
+}
+
+fn build_object(obj: &Map<String, Value>, builder: &mut ObjectBuilder) ->
Result<(), ArrowError> {
+ for (key, value) in obj.iter() {
+ match value {
+ Value::Null => builder.append_value(key, Variant::Null),
+ Value::Bool(b) => builder.append_value(key, *b),
+ Value::Number(n) => {
+ let v: Variant = n.try_into()?;
+ builder.append_value(key, v)
+ }
+ Value::String(s) => builder.append_value(key, s.as_str()),
+ Value::Array(_) | Value::Object(_) => {
+ todo!("Nesting within objects unsupported right now.");
+ }
Review Comment:
Nesting support for objects was merged a few hours ago and has been
incorporated into the latest version of this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
