zanmato1984 commented on code in PR #46922: URL: https://github.com/apache/arrow/pull/46922#discussion_r2174718000
########## cpp/src/arrow/dataset/CMakeLists.txt: ########## @@ -207,8 +207,8 @@ if(ARROW_PARQUET) endif() if(ARROW_BUILD_BENCHMARKS) - add_arrow_benchmark(file_benchmark PREFIX "arrow-dataset") - add_arrow_benchmark(scanner_benchmark PREFIX "arrow-dataset") + add_arrow_compute_benchmark(file_benchmark PREFIX "arrow-dataset") + add_arrow_compute_benchmark(scanner_benchmark PREFIX "arrow-dataset") Review Comment: I think having a wrapper is nice. It not only hides the underlying implementation (leveraging `add_arrow_compute_benchmark`) thus making the invocation more explicit, but also sorts out other subproject specific logic (such as prepending the name prefix). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
