pitrou commented on code in PR #44739: URL: https://github.com/apache/arrow/pull/44739#discussion_r2177075328
########## cpp/src/parquet/stream_writer.h: ########## @@ -151,6 +151,23 @@ class PARQUET_EXPORT StreamWriter { StreamWriter& operator<<(const std::string& v); StreamWriter& operator<<(::std::string_view v); + /// \brief Helper class to write variable length raw data. Review Comment: How about `using RawDataView = std::basic_string_view<uint8_t>` instead? Perhaps we don't need to create yet another string-view-like class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org