pitrou commented on code in PR #44739: URL: https://github.com/apache/arrow/pull/44739#discussion_r2180300380
########## cpp/src/parquet/stream_writer.cc: ########## @@ -183,6 +187,28 @@ StreamWriter& StreamWriter::WriteFixedLength(const char* data_ptr, std::size_t d return *this; } +StreamWriter& StreamWriter::WriteRawDataVariableLength(const uint8_t* data_ptr, Review Comment: This is almost exactly the same code as in `WriteVariableLength`, right? Can you refactor these methods to share the common parts? (only `CheckColumn` and the pointer cast seem to differ...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
