pitrou commented on code in PR #46961:
URL: https://github.com/apache/arrow/pull/46961#discussion_r2177958431
##########
python/pyarrow/_dataset.pyx:
##########
@@ -3162,6 +3172,20 @@ cdef class DatasetFactory(_Weakrefable):
cdef:
CInspectOptions options
CResult[shared_ptr[CSchema]] result
+
+ if promote_options == "permissive":
+ options.field_merge_options = CField.CMergeOptions.Permissive()
+ elif promote_options != "default":
+ raise ValueError(f"Invalid merge mode: {promote_options}")
Review Comment:
Nit: reflect actual parameter name?
```suggestion
raise ValueError(f"Invalid promote_options: {promote_options}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
