hadrian-reppas commented on code in PR #46961:
URL: https://github.com/apache/arrow/pull/46961#discussion_r2178319698
##########
python/pyarrow/_dataset.pyx:
##########
@@ -3162,6 +3172,20 @@ cdef class DatasetFactory(_Weakrefable):
cdef:
CInspectOptions options
CResult[shared_ptr[CSchema]] result
+
+ if promote_options == "permissive":
Review Comment:
I've been fighting with Cython for a few hours.
[This](https://github.com/hadrian-reppas/arrow/commit/534aa6148b8628229b77543e2e7fbfe1b686becd)
is the closest I've gotten to making it work. Adding the definition of
`_parse_field_merge_options` in other places I tried caused circular imports,
so I put it in a different file. Even though I added _util to setup.py, I still
get an import error:
```
>>> import pyarrow
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/hadrian/dev/arrow/python/pyarrow/__init__.py", line 61, in
<module>
import pyarrow.lib as _lib
File "pyarrow/lib.pyx", line 1, in init pyarrow.lib
# Licensed to the Apache Software Foundation (ASF) under one
ModuleNotFoundError: No module named 'pyarrow._util'
```
I'll keep working on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
