alamb commented on code in PR #7843:
URL: https://github.com/apache/arrow-rs/pull/7843#discussion_r2178410429


##########
parquet-variant/src/builder.rs:
##########
@@ -1452,6 +1510,9 @@ mod tests {
             "Invalid argument error: Duplicate field keys detected: [x]"
         );
 
+        inner_list.finish();
+        outer_list.finish();
+

Review Comment:
   awesome -- i also think it is a great example of how this change improves 
the variant builders



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to