alamb commented on code in PR #7824:
URL: https://github.com/apache/arrow-rs/pull/7824#discussion_r2182513672


##########
parquet/src/encodings/rle.rs:
##########
@@ -135,7 +136,7 @@ impl RleEncoder {
         } else {
             if self.repeat_count >= 8 {
                 // The current RLE run has ended and we've gathered enough. 
Flush first.
-                assert_eq!(self.bit_packed_count, 0);
+                debug_assert_eq!(self.bit_packed_count, 0);

Review Comment:
   it is a good call to remove the runtime overhead in release mode



##########
parquet/src/arrow/arrow_writer/levels.rs:
##########
@@ -566,6 +568,9 @@ pub(crate) struct ArrayLevels {
 
     /// The arrow array
     array: ArrayRef,
+
+    /// cached logical nulls of the array.

Review Comment:
   This is also a good idea to avoid having to clone (even though it is just a 
few ars) each time



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to