pitrou commented on code in PR #46987:
URL: https://github.com/apache/arrow/pull/46987#discussion_r2184662116
##########
cpp/src/arrow/compute/kernels/scalar_string_test.cc:
##########
@@ -2271,7 +2279,7 @@ TYPED_TEST(TestStringKernels, UTF8ZeroFill) {
R"(["xxx1", "-xx2", "+xx3"])", &options);
// Non-ASCII padding character
- options = ZeroFillOptions{/*width=*/5, u8"💠"};
+ options = ZeroFillOptions{/*width=*/5, "💠"s};
Review Comment:
It wasn't necessary to add the literal, was it? A plain C string would
probably have worked: `"💠"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
