pitrou commented on code in PR #46987:
URL: https://github.com/apache/arrow/pull/46987#discussion_r2184663071
##########
cpp/src/arrow/compute/kernels/scalar_string_test.cc:
##########
@@ -2247,6 +2247,14 @@ TYPED_TEST(TestStringKernels, PadUTF8) {
}
TYPED_TEST(TestStringKernels, UTF8ZeroFill) {
+ // Visual Studio 2019 doesn't like the following:
+ // using std::literals::string_literals::operator""s;
+ //
+ // Message from Visual Studio 2019:
+ // warning C4455: 'operator ""s': literal suffix identifiers that
+ // do not start with an underscore are reserved
+ using namespace std::literals::string_literals; //
NOLINT(build/namespaces_literals)
Review Comment:
I don't think this is useful, see below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
