scovich commented on code in PR #7833:
URL: https://github.com/apache/arrow-rs/pull/7833#discussion_r2187203732


##########
parquet-variant/src/builder.rs:
##########
@@ -299,6 +324,23 @@ impl MetadataBuilder {
     }
 }
 
+impl<S: AsRef<str>> FromIterator<S> for MetadataBuilder {

Review Comment:
   Out of curiosity, why `AsRef<str>` instead of `Into<String>`? The former 
forces a copy even when passing owned strings. 
   
   Tho IMO this is a messy part of rust... we really want something 
`Cow`-flavored that handles all of `Deref` + `Borrow` + `AsRef` + `Into`... 
today you have to pick just one, because adding a second causes ambiguity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to