friendlymatthew commented on code in PR #7833:
URL: https://github.com/apache/arrow-rs/pull/7833#discussion_r2187217591


##########
parquet-variant/src/builder.rs:
##########
@@ -299,6 +324,23 @@ impl MetadataBuilder {
     }
 }
 
+impl<S: AsRef<str>> FromIterator<S> for MetadataBuilder {

Review Comment:
   That is fair. I chose `AsRef<str>` since the `upsert_field_name` took a 
`&str`. Since `upsert_field_name` is a public method, I chose not to update the 
function header and work around this. 
   
   As for using `Cow`s, I think this is a really good idea. There are some 
areas where I feel like we could really benefit from using it. For example:
   
   <img width="868" alt="Screenshot 2025-07-05 at 8 44 18 AM" 
src="https://github.com/user-attachments/assets/4d77d186-263b-4df7-a4d0-f900afcfae8d";
 />
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to