phillipleblanc commented on code in PR #3099:
URL: https://github.com/apache/arrow-adbc/pull/3099#discussion_r2187837806
##########
rust/core/src/driver_manager.rs:
##########
@@ -276,6 +351,23 @@ impl ManagedDriver {
Ok(database)
}
+
+ fn load_driver_from_manifest(
+ driver_path: &Path,
+ entrypoint: Option<&[u8]>,
+ version: AdbcVersion,
+ ) -> Result<Self> {
+ let mut info = DriverInfo {
+ manifest_file: driver_path.to_path_buf(),
+ driver_name: String::new(),
+ lib_path: PathBuf::new(),
+ entrypoint: entrypoint.map(|e| e.to_vec()),
+ version: String::new(),
+ source: String::new(),
Review Comment:
You can also write the type name, i.e. `DriverInfo::default()` - this is
also a pedantic clippy lint:
https://rust-lang.github.io/rust-clippy/master/index.html#default_trait_access
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
