zanmato1984 commented on code in PR #46898:
URL: https://github.com/apache/arrow/pull/46898#discussion_r2189346502
##########
cpp/src/arrow/acero/options.h:
##########
@@ -723,10 +723,14 @@ class ARROW_ACERO_EXPORT AsofJoinNodeOptions : public
ExecNodeOptions {
/// \see `Keys` for details.
std::vector<Keys> input_keys;
/// \brief Tolerance for inexact "on" key matching. A right row is
considered a match
- /// with the left row if `right.on - left.on <= tolerance`. The `tolerance`
may be:
- /// - negative, in which case a past-as-of-join occurs;
- /// - or positive, in which case a future-as-of-join occurs;
- /// - or zero, in which case an exact-as-of-join occurs.
+ /// with a left row if `right.on - left.on` is between 0 and `tolerance`.
`tolerance`
+ /// may be:
Review Comment:
```suggestion
/// with a left row if `right.on - left.on` is within the range `[min(0,
tolerance),
/// max(0, tolerance)]`. `tolerance` may be:
```
##########
cpp/src/arrow/acero/options.h:
##########
@@ -700,8 +700,8 @@ class ARROW_ACERO_EXPORT AsofJoinNodeOptions : public
ExecNodeOptions {
/// \brief "on" key for the join.
///
/// The input table must be sorted by the "on" key. Must be a single field
of a common
- /// type. Inexact match is used on the "on" key. i.e., a row is considered
a match iff
- /// left_on - tolerance <= right_on <= left_on.
+ /// type. An inexact match is used on the "on" key, i.e. a row is
considered a
+ /// match if and only if `right.on - left.on` is between 0 and `tolerance`.
Review Comment:
```suggestion
/// match if and only if `right.on - left.on` is `right.on - left.on` is
within the
/// range `[min(0, tolerance), max(0, tolerance)]`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
