alamb commented on code in PR #7877:
URL: https://github.com/apache/arrow-rs/pull/7877#discussion_r2190744870
##########
arrow-array/benches/view_types.rs:
##########
@@ -43,6 +55,21 @@ fn criterion_benchmark(c: &mut Criterion) {
});
});
+ let array = gen_view_array_without_nulls(100_000);
Review Comment:
100_000 seems like an overly large array to be checking (though I see the
other benchmarks also use that number)
Given we recommend batch sizes more ike 8k, maybe we should change the
benchmark (in a follow on PR) to use 10K or 8K rows instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
