pitrou commented on code in PR #46961:
URL: https://github.com/apache/arrow/pull/46961#discussion_r2192297003


##########
python/pyarrow/lib.pxd:
##########
@@ -678,6 +678,8 @@ cdef shared_ptr[const CKeyValueMetadata] 
pyarrow_unwrap_metadata(
 cdef object pyarrow_wrap_metadata(
     const shared_ptr[const CKeyValueMetadata]& meta)
 
+cdef CField.CMergeOptions _parse_field_merge_options(str promote_options, bint 
allow_none) except *

Review Comment:
   Please let's make the boolean parameter keyword-only (if supported by 
Cython).
   ```suggestion
   cdef CField.CMergeOptions _parse_field_merge_options(str promote_options, *, 
bint allow_none) except *
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to