andishgar commented on code in PR #46385:
URL: https://github.com/apache/arrow/pull/46385#discussion_r2192347620
##########
cpp/src/arrow/array/statistics_test.cc:
##########
@@ -81,6 +92,14 @@ TEST(TestArrayStatistics, EqualityNonDoulbeValue) {
statistics2.distinct_count = 2929;
ASSERT_EQ(statistics1, statistics2);
+ // Although this assertion is meaningless without average_byte_width,
+ // the purpose here is simply to check whether is_average_byte_width_exact
+ // is included in the Equality.
+ statistics1.is_average_byte_width_exact = true;
+ ASSERT_NE(statistics1, statistics2);
+ statistics2.is_average_byte_width_exact = true;
+ ASSERT_EQ(statistics1, statistics2);
+
Review Comment:
Actually, this test case is for non-double attributes, and I use non-double
values for `min` and `max` here.
I created the test cases for double attributes in my last commit under the
name `DoubleAttributesCombination`, which include similar assertions for double
values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
