scovich commented on PR #7878: URL: https://github.com/apache/arrow-rs/pull/7878#issuecomment-3058405343
> avoid materializing offsets + remove redundant checks Honestly, this one feels like a good fast-follow, rather than something that would block the merge? Unless it's super easy/fast to clean up. Perfection as enemy of good and all that. As @viirya pointed out, this PR adds some validations that were just plain missing before. Also, as a separate PR we could hopefully even see benchmark results quantifying the impact of the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
