davidhewitt commented on code in PR #7716: URL: https://github.com/apache/arrow-rs/pull/7716#discussion_r2198433393
########## arrow-select/src/dictionary.rs: ########## @@ -110,7 +168,7 @@ type PtrEq = fn(&dyn Array, &dyn Array) -> bool; /// some return over the naive approach used by MutableArrayData /// /// `len` is the total length of the merged output -pub fn should_merge_dictionary_values<K: ArrowDictionaryKeyType>( +pub(crate) fn should_merge_dictionary_values<K: ArrowDictionaryKeyType>( Review Comment: Yes - I made `dictionary.rs` a `pub mod` so that `arrow_select::dictionary::garbage_collect_dictionary` can be the public API path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
