zeroshade opened a new pull request, #440:
URL: https://github.com/apache/arrow-go/pull/440

   ### Rationale for this change
   An issue was discovered in https://github.com/apache/iceberg-go when working 
with compacted files and parquet files written by pyiceberg. Essentially it 
boiled down to the fact that if an expression contained a Field Reference to a 
LargeString field, evaluation would fail as it expected `String` and not 
`LargeString` when converting from the Substrait types. This difference 
shouldn't cause an issue so we need to ensure that LargeString is allowed when 
String is expected, same for LargeBinary and Binary
   
   ### What changes are included in this PR?
   Simply adding a case to the error condition when the types aren't equal to 
allow String + LargeString or Binary + LargeBInary to be allowed.
   
   ### Are these changes tested?
   A unit test has been added to test it.
   
   ### Are there any user-facing changes?
   Just the new case being allowed when it was previously disallowed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to