zeroshade commented on code in PR #3150:
URL: https://github.com/apache/arrow-adbc/pull/3150#discussion_r2205845821
##########
go/adbc/ext.go:
##########
@@ -78,3 +81,55 @@ type OTelTracing interface {
// Gets the initial span attributes for any newly started span.
GetInitialSpanAttributes() []attribute.KeyValue
}
+
+// IngestStreamOption bundles the most-common IngestStream settings.
+// Any other ADBC options can go into Extra.
+type IngestStreamOption struct {
+ TargetTable string // required
+ IngestMode string // required, e.g.
adbc.OptionValueIngestModeCreateAppend, or OptionValueIngestModeReplace
+ Extra map[string]string // any other stmt.SetOption(...) args
Review Comment:
since these are required, should we make them explicit parameters instead of
behind this struct? i.e.
```go
func IngestStream(ctx context.Context, cnxn Connection, reader
array.RecordReader, target, mode string, extra map[string]string) (int64, error)
```
what do you think? @lidavidm thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
