lidavidm commented on code in PR #3150:
URL: https://github.com/apache/arrow-adbc/pull/3150#discussion_r2205970393
##########
go/adbc/ext.go:
##########
@@ -78,3 +81,55 @@ type OTelTracing interface {
// Gets the initial span attributes for any newly started span.
GetInitialSpanAttributes() []attribute.KeyValue
}
+
+// IngestStreamOption bundles the most-common IngestStream settings.
+// Any other ADBC options can go into Extra.
+type IngestStreamOption struct {
+ TargetTable string // required
+ IngestMode string // required, e.g.
adbc.OptionValueIngestModeCreateAppend, or OptionValueIngestModeReplace
+ Extra map[string]string // any other stmt.SetOption(...) args
Review Comment:
I could go either way, but the struct may make it easier to add new
parameters in the future? That said I don't mind table/mode being just formal
parameters and having struct fields for things like temporary/catalog/schema,
and keeping Extra for any driver-specific options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
