rok commented on code in PR #12865: URL: https://github.com/apache/arrow/pull/12865#discussion_r2207933995
########## cpp/src/arrow/compute/kernels/temporal_internal.h: ########## @@ -40,15 +39,42 @@ using arrow_vendored::date::year_month_day; using arrow_vendored::date::zoned_time; using std::chrono::duration_cast; +using ArrowTimeZone = std::variant<const time_zone*, const OffsetZone>; Review Comment: I wanted to store `OffsetZone` in `ArrowTimeZone` by reference but couldn't without smart pointers. I'd keep this as you suggested: ```python using ArrowTimeZone = std::variant<const time_zone*, OffsetZone>; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
