Re: [PR] ARROW-14477: [C++] Timezone-aware kernels should handle offset strings (e.g. "+04:30") [arrow]

[via GitHub]

rok commented on code in PR #12865:
URL: https://github.com/apache/arrow/pull/12865#discussion_r2205764115


##########
cpp/src/arrow/compute/kernels/temporal_internal.h:
##########
@@ -40,15 +39,42 @@ using arrow_vendored::date::year_month_day;
 using arrow_vendored::date::zoned_time;
 using std::chrono::duration_cast;
 
+using ArrowTimeZone = std::variant<const time_zone*, const OffsetZone>;

Review Comment:
   @pitrou I tried:
   ```cpp
   using ArrowTimeZone = std::variant<const time_zone*, const OffsetZone>;
   ```
   but it was a bit difficult to not have OffsetZone go out of scope. I think 
this is fine though/



##########
cpp/src/arrow/compute/kernels/temporal_internal.h:
##########
@@ -40,15 +39,42 @@ using arrow_vendored::date::year_month_day;
 using arrow_vendored::date::zoned_time;
 using std::chrono::duration_cast;
 
+using ArrowTimeZone = std::variant<const time_zone*, const OffsetZone>;

Review Comment:
   @pitrou I tried:
   ```cpp
   using ArrowTimeZone = std::variant<const time_zone*, const OffsetZone>;
   ```
   but it was a bit difficult to not have OffsetZone go out of scope. I think 
this is fine though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org