jonkeane commented on pull request #9898: URL: https://github.com/apache/arrow/pull/9898#issuecomment-818078421
OK, I think that I've addressed all of the comments except for https://github.com/apache/arrow/pull/9898/files#r610775175 (though the GH interface + the number of commits here doesn't make it easy to ensure that I have!) > Can you also delete the corresponding content from README.md? We will, though the plan is to do this after both this PR and ARROW-11477 are completed so we don't conflict + don't accidentally remove something without it going in one of the new locations first. > I would lead with [system install] and then what you're doing is adding -DCMAKE_INSTALL_PREFIX=$ARROW_HOME Since this section and the one above it are under {.tabset} they will be tabbed, such that one or the other will be displayed on pkgdown (in the local-vignette* it will be in this order, but I suspect that the vast majority of people looking at these look at the pkgdown site). Since this is the case, for either we will have the full `cmake` command such that each tab is a full install, just of the two different types. I'm a bit torn as to if we should recommend system-install or user-dir-install. I've listed the pros/cons for system-install but they are the mirror image, so flip them for the pros/cons for user-dir-install. system-install pros: * easier in many cases (don't need to deal with `LD_LIBRARY_PATH` on linux) * more natural install for R system-install cons: * clobbers system installs of Arrow * can only have one libarrow around at a time * isn't aligned with python or c++ docs I'm leaning towards recommending the user-dir-install to align with other developer docs. We could also suggest building bundled builds where we bundle the needed Arrow library dependencies into the R package. I'm hesitant to go in that direction because either one will have to rebuild libarrow each time the r package is installed, or maintain (and prevent from being deleted) the pre-built libarrow under `arrow/r/libarrow`. We might be able to put that in a different place and recommend that, but that starts being very similar to the user-dir-install approach. * - The local-vignette *does* strip out the {.tabset} attribute, but it doesn't support tabs so they aren't there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
