nealrichardson commented on a change in pull request #9898:
URL: https://github.com/apache/arrow/pull/9898#discussion_r611908792
##########
File path: r/configure
##########
@@ -66,8 +66,12 @@ if [ "$FORCE_AUTOBREW" = "true" ] || [
"$FORCE_BUNDLED_BUILD" = "true" ]; then
fi
# Note that cflags may be empty in case of success
-if [ "$INCLUDE_DIR" ] || [ "$LIB_DIR" ]; then
- echo "*** Using INCLUDE_DIR/LIB_DIR"
+if [ "$ARROW_HOME" ]; then
+ echo "*** Using ARROW_HOME as the source of libarrow"
+ PKG_CFLAGS="-I$ARROW_HOME/include $PKG_CFLAGS"
+ PKG_DIRS="-L$ARROW_HOME/lib"
+elif[ "$INCLUDE_DIR" ] || [ "$LIB_DIR" ]
Review comment:
```suggestion
elif [ "$INCLUDE_DIR" ] || [ "$LIB_DIR" ]
```
also I've never understood why this was valid as an `||` instead of `&&` 🤷
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
