scovich opened a new pull request, #7956:
URL: https://github.com/apache/arrow-rs/pull/7956

   # Which issue does this PR close?
   
   - Follow-up to https://github.com/apache/arrow-rs/issues/7901
   
   # Rationale for this change
   
   - https://github.com/apache/arrow-rs/pull/7934/
   
   Introduced a minor regression, in (accidentally?) forbidding the empty 
string as a dictionary key. Fix the bug and simplify the code a bit further 
while we're at it.
   
   # What changes are included in this PR?
   
   Revert the unsorted dictionary check back to what it had been (it just uses 
`Iterator::is_sorted_by` now, instead of `primitive.slice::is_sorted_by`).
   
   Remove the redundant offset monotonicity check from the ordered dictionary 
path, relying on the fact that string slice extraction will anyway fail if the 
offsets are not monotonic. Improve the error message now that it does double 
duty.
   
   # Are these changes tested?
   
   New unit tests for dictionaries containing the empty string. As a side 
effect, we now have at least a little coverage for sorted dictionaries -- 
somehow, I couldn't find any existing unit test that creates a sorted 
dictionary??
   
   # Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to