codephage2020 commented on code in PR #7956:
URL: https://github.com/apache/arrow-rs/pull/7956#discussion_r2216344593
##########
parquet-variant/src/variant/metadata.rs:
##########
@@ -240,28 +240,23 @@ impl<'m> VariantMetadata<'m> {
let value_buffer =
string_from_slice(self.bytes, 0, self.first_value_byte as
_..self.bytes.len())?;
- let mut offsets_iter = map_bytes_to_offsets(offset_bytes,
self.header.offset_size);
- let mut current_offset = offsets_iter.next().unwrap_or(0);
+ let mut offsets = map_bytes_to_offsets(offset_bytes,
self.header.offset_size);
Review Comment:
An insignificant point. I named it *_iter, which exists in both metadata and
object. If you want to make modifications, they should be consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
