alamb commented on code in PR #7946:
URL: https://github.com/apache/arrow-rs/pull/7946#discussion_r2216789293


##########
parquet-variant-compute/src/field_operations.rs:
##########
@@ -0,0 +1,532 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Field extraction and removal operations for variant objects
+
+use crate::variant_parser::{ObjectHeader, ObjectOffsets, VariantParser};
+use arrow::error::ArrowError;
+use parquet_variant::VariantMetadata;
+use std::collections::HashSet;
+
+/// Represents a path element in a variant path

Review Comment:
   I am not quite sure what you are asking. 
   
   I think it might help to move shredded variant forward by writing the tests 
/ examples of how variant_get should work with shredded arrays
   
   I tried to work up a simple example here:
   - https://github.com/apache/arrow-rs/pull/7965
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to