jecsand838 commented on code in PR #7954:
URL: https://github.com/apache/arrow-rs/pull/7954#discussion_r2216795716
##########
arrow-avro/src/reader/record.rs:
##########
@@ -301,9 +301,23 @@ impl Decoder {
}
Codec::Uuid => Self::Uuid(Vec::with_capacity(DEFAULT_CAPACITY)),
};
- Ok(match data_type.nullability() {
- Some(nullability) => Self::Nullable(
- nullability,
+ let union_order = match data_type.nullability() {
+ None => None,
+ Some(Nullability::NullFirst) => Some(Nullability::NullFirst),
+ Some(Nullability::NullSecond) => {
+ if strict_mode {
+ return Err(ArrowError::ParseError(
+ "Found Avro union of the form ['T','null'], which is
disallowed in strict_mode"
+ .to_string(),
+ ));
+ }
+ Some(Nullability::NullSecond)
+ }
+ };
Review Comment:
@veronica-m-ef Looking good! I just left three small follow-up suggestions.
@alamb @scovich Would either of you be able to give this a review when you
get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
